YJIT: Initialize Assembler vectors with capacity #8437
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at perf profiling results on 30k_ifelse, I noticed
x86_split
andalloc_regs
spend a considerable amount of time inpush_insn
, which spends majority of time inVec::push
.To make these
Vec::push
calls faster, this PR sets initial capacity to the vectors modified bypush_insn
.Size of asm.insns
I checked the max
asm.insns.len()
in the following benchmarks:asm.insns.len()
To accommodate
Insn
s for these benchmarks, I chose 256.size_of::<Insn>()
is 80, so each vector has 80 * 256 = 20KiB. Having up to four of such vectors at a time would consume 80KiB extra memory, but it doesn't seem significant compared to what the interpreter uses, and these vectors are transient anyway.Benchmarks: 1st itr
This speeds up the 1st itr of
30k_ifelse
by 7%. It also speeds uplobsters
,ruby-lsp
, and30k_methods
. It doesn't seem to have a significant impact on RSS.