Add 3.3.0-preview2-pshopify1

[k0kubun]

We're preparing for globally deploying 3.3.0-preview2 on SFR. 3.3.0-preview2 is fine as is, but I backported things that are nice to have and slipped from preview2.

• Parallelize make again:
  • .NOTPARALLEL with prerequisites needs recent GNU Make ruby/ruby#8489
• Speed up YJIT compilation:
  • YJIT: Initialize Assembler vectors with capacity ruby/ruby#8437
  • YJIT: Initialize Vec with capacity for iterators ruby/ruby#8439
  • YJIT: Skip Insn::Comment and format! if disasm is disabled ruby/ruby#8441
  • YJIT: Avoid creating a vector in get_temp_regs() ruby/ruby#8446
• Crash report:
  • [Feature #19790] Crash report ruby/ruby#8506

[peterzhu2118]

Do we want to add a definition for 3.3.0-preview2-pshopify1 rather than just building with a SHA in the services we're experimenting on?

[k0kubun]

just building with a SHA in the services we're experimenting on

In case it wasn't clear, this version is not for experimental clusters but supposed to be deployed to services like SFR (all clusters) and Core, and therefore it will be installed in development environments too. While I do intend to use it as a way to test the version works well before it's actually released, I want these versions to be relatively stable (definitely don't deploy MaNy once merged, until it gets stabilized) and mainly ship bugfixes and performance improvements, instead of things "we're experimenting on". It's as non-experimental as 3.2.2-pshopify.

I think we want to eventually get to the point where you can install precompiled binaries for these Ruby versions at least for our internal gems as Jean said. When we do so, it'd be nice to use a versioning scheme like 3.3.0-fooX-pshopifyY where fooX can be used as an ABI version so that you don't need to release a binary for every single gem whenever you change a sha (bump pshopifyY).

I don't care whether we use a preview version or not. We could pick a random sha and call it 3.3.0-shopifypreview1 and then release 3.3.0-shopifypreview1-pshopify1, 3.3.0-shopifypreview1-pshopify2, and so on. But I think it should have a name like that so that tools like dev can figure out ABI compatibility just from version names.

Since 3.3.0-preview2 happens to be new and stable enough, I just picked that as a base version for the ABI part instead of inventing a name like shopifypreview1 just yet.

[peterzhu2118]

I see. We need to change this sorting algorithm to rank -preview to be lower because otherwise 3.3.0-preview2-pshopify1 will be ranked higher than 3.3.0-pshopify1.

ruby-definitions/lib/shopify_ruby_definitions/ruby_versions.rb

Line 8 in e4cf1cf

version.scan(/\d+/).map(&:to_i)

[casperisfine]

It would be good to backport the crash reporter patch as well, so that if we run into bugs in production we get decent reports.

https://github.com/nobu/ruby/tree/crash_report

[k0kubun]

I see. We need to change this sorting algorithm to rank -preview to be lower because otherwise 3.3.0-preview2-pshopify1 will be ranked higher than 3.3.0-pshopify1.

Thanks for catching it. I fixed it to use different keys for 3.3.0 and 3.3.0-preview2 d58057a, so it's still ranked higher but they don't conflict. I think we should specify ruby: 3.3.0-preview2 to use a preview version instead of resolving ruby: 3.3 to 3.3.0-preview2.

It would be good to backport the crash reporter patch as well, so that if we run into bugs in production we get decent reports.

Backported ruby/ruby#8506 in 16bb3b2.