Make Net::HTTP tests ensure local & remote hosts are same addr family #9698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* When making connections wiht TCPSocket.new and friends, we resolve the
passed-in hostname with AI_ADDRCONFIG.
* AI_ADDRCONFIG means (in practice) "do not make AAAA queries or return
any IPv6 addresses unless this machine has a network interface with an
IPv6 address".
* The loopback adapter does _NOT_ count as "a network interface with an
IPv6 address" for this check; your machine must have some _other_, non
loopback address.
This causes issues with the Net::HTTP tests which set the local_host to
connect _from_. This obviously needs to have the same address family as
the host to connect _to_. However, we call Addrinfo.tcp('localhost')
_without_ AI_ADDRCONFIG to set this, which means it might be `::1` even
in circumstances where the lookup done on the hostname to connect _to_
(also 'localhost') returns `127.0.0.1`.
Fix this by passing a hostname into `local_host=`, not an address; the
hostname will be resolved with the same address family used for
connecting.
[Bug #20208]
|
We decided to just revert the whole AI_ADDRCONFIG thing instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes issues with the Net::HTTP tests which set the local_host to connect from. This obviously needs to have the same address family as the host to connect to. However, we call Addrinfo.tcp('localhost')
without AI_ADDRCONFIG to set this, which means it might be
::1evenin circumstances where the lookup done on the hostname to connect to (also 'localhost') returns
127.0.0.1.Fix this by passing a hostname into
local_host=, not an address; the hostname will be resolved with the same address family used for connecting.https://bugs.ruby-lang.org/issues/20208