Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alias .string to .to_s #102

Closed
sebyx07 opened this issue Aug 20, 2024 · 2 comments
Closed

Alias .string to .to_s #102

sebyx07 opened this issue Aug 20, 2024 · 2 comments

Comments

@sebyx07
Copy link

sebyx07 commented Aug 20, 2024

imo, a lot of users would rather call buffer.to_s instead of the .string method, nobody atm depends on the .to_s. There already is .inspect that behaves like the current to_s

https://bugs.ruby-lang.org/issues/20703?next_issue_id=20702

I can do a pr, but lmk if it's a good idea

@kou
Copy link
Member

kou commented Aug 21, 2024

I'm not sure whether the change is safe or not but let's try.

@sebyx07
Copy link
Author

sebyx07 commented Aug 28, 2024

also added .to_str https://bugs.ruby-lang.org/issues/20703

@nobu nobu closed this as completed Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants