Relax ruby version to include 2.4 or earlier?

[MSP-Greg]

I've noticed the constraint on the current WEBrick of ruby 2.5. I have not tried a Travis build on my fork to see if it works with 2.3 or 2.4.

Might the constraint be relaxed to include at least Ruby 2.4?

I checked it against a few local builds I have, and it passed for all the MSYS2 based builds, which is 2.3.5 forward. Also, passed a trunk vc140.

ruby 2.3.5p376 (2017-09-14 revision 59905) [x64-mingw32]   ruby-loco
ruby 2.4.2p198 (2017-09-14 revision 59899) [x64-mingw32]   standard RubyInstaller2

ruby 2.5.0dev  (2017-12-11 trunk 61097) [x64-mswin64_140]  custom vc140 and OpenSSL, zlib
ruby 2.5.0dev  (2017-12-15 trunk 61278) [x64-mingw32]      ruby-loco

It did fail on the current RubyInstaller build, 2.3.3.

Below is info from the 2.3 tests, not sure about the issue with 2.3.5...

Thanks, Greg

Ruby 2.3.3 - current RubyInstaller 2.3 build

  1) Failure:
TestWEBrickHTTPS#test_sni [E:/GitHub/webrick/test/webrick/utils.rb:64]:
exceptions on 1 threads:
#<Thread:0x000000031f4d90@E:/GitHub/webrick/test/webrick/utils.rb:57 dead>:
E:/GitHub/webrick/test/lib/minitest/unit.rb:201:in `assert': <"/CN=vhost1"> expected but was
<"/CN=localhost">. (MiniTest::Assertion)
        from E:/GitHub/webrick/test/lib/test/unit/assertions.rb:37:in `assert'
        from E:/GitHub/webrick/test/lib/test/unit/assertions.rb:298:in `assert_equal'
        from E:/GitHub/webrick/test/webrick/test_https.rb:41:in `https_get'
        from E:/GitHub/webrick/test/webrick/test_https.rb:93:in `block in test_sni'
        from E:/GitHub/webrick/test/webrick/utils.rb:59:in `block in start_server'

101 tests, 713 assertions, 1 failures, 0 errors, 0 skips

ruby -v: ruby 2.3.3p222 (2016-11-21 revision 56859) [x64-mingw32]

Ruby 2.3.5 - Custom RubyInstaller2 / ruby-loco build

[ 27/101] TestWEBrickHTTPProxy#test_connect
E:/r_builds/not_trunk/23_2.3.5/ruby23_64/lib/ruby/2.3.0/openssl/buffering.rb:324: warning: SSL session is not started yet.
E:/r_builds/not_trunk/23_2.3.5/ruby23_64/lib/ruby/2.3.0/openssl/buffering.rb:181: warning: SSL session is not started yet.
E:/r_builds/not_trunk/23_2.3.5/ruby23_64/lib/ruby/2.3.0/openssl/buffering.rb:181: warning: SSL session is not started yet.
E:/r_builds/not_trunk/23_2.3.5/ruby23_64/lib/ruby/2.3.0/openssl/buffering.rb:324: warning: SSL session is not started yet.
E:/r_builds/not_trunk/23_2.3.5/ruby23_64/lib/ruby/2.3.0/openssl/buffering.rb:181: warning: SSL session is not started yet.
E:/r_builds/not_trunk/23_2.3.5/ruby23_64/lib/ruby/2.3.0/openssl/buffering.rb:181: warning: SSL session is not started yet.
 = 2.90 s

101 tests, 718 assertions, 0 failures, 0 errors, 0 skips

ruby -v: ruby 2.3.5p376 (2017-09-14 revision 59905) [x64-mingw32]
WEBrick::VERSION 1.4.0.beta1

[MSP-Greg]

Never mind. Seems the most recent gem was generated from ruby/ruby, not here. Looking over there...

[hsbt]

@MSP-Greg This repository is a mirror. So, We can test webrick gem with Travis CI only GitHub Repository. (Eric Wong never use GitHub)

I think that webrick can be supported '>= Ruby 2.4'.

[MSP-Greg]

@hsbt Yeah, I kind of auto-piloted' to this repo, assuming that the gem was built from it. Then the light bulb went off... Thanks, Greg

[MSP-Greg]

@hsbt
I added version tests around the two warn statements (see fork commit, assumes 2.10 never exists),

Appveyor build passed 2.4.2 & trunk

Travis build passed 2.4.1, 2.4.3 & trunk (also 2.3.6)...

FYI, thanks, Greg