Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra Login button and make Logout button match #79

Closed
2 tasks
datadaveshin opened this issue Apr 7, 2020 · 3 comments · Fixed by #82
Closed
2 tasks

Remove extra Login button and make Logout button match #79

datadaveshin opened this issue Apr 7, 2020 · 3 comments · Fixed by #82
Assignees
Labels
⏯️ Frontend Make things look fresh & work better on the frontend.

Comments

@datadaveshin
Copy link
Collaborator

  • There is an extra Login button at the bottom of the Login page, which isn't functional - I assume the functional one above came from Devise - which should be removed:
  • The Logout button should be updated to match the Login button

Here are the Login buttons:
Login Screen Shot 2020-04-06 at 7 14 08 PM


Here is the Logout button
Logout 2020-04-06 at 7 13 31 PM

@compwron
Copy link
Collaborator

compwron commented Apr 7, 2020

Thanks for this great issue! I agree we should do this :)

@compwron compwron added the ⏯️ Frontend Make things look fresh & work better on the frontend. label Apr 7, 2020
@datadaveshin datadaveshin self-assigned this Apr 7, 2020
@datadaveshin
Copy link
Collaborator Author

I'll try to fix it by tomorrow morning

@datadaveshin
Copy link
Collaborator Author

My bad, I later realized the dark blue bars with "Login" and "Logout" at the bottom were meant to be in a footer originally so we could log in and out to get the app rolling.

Looks like the mockup has the "Login" and "Logout" buttons in the navbar, so move there?

Navbar from wiki:
navbar Screen Shot 2020-04-07 at 7 14 35 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⏯️ Frontend Make things look fresh & work better on the frontend.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants