Identify models that have side effect problems when their records are deleted

[armahillo]

Ref #248, #249, #243, #239 (indirectly), #223, #258

Deleting stuff is causing problems. The users are doing stuff they're allowed to, there's just side effects that we didn't anticipate with how deleting individual items might affect the associations with other items.

We should review all the models for:

• Do users really need to be able to delete records
• How should deletions be handled
• What related models need to be checked for integrity if something is deleted

[seanmarcia]

I think if we add in a gem like acts_as_paranoid or archivable we could achieve the same result of "deleting" an item but keeping it in the background of we need it again.

[dacur]

This is also a feature of RuboCop, which is something I'm working on adding (see #290) and the docs. It will notify you, for instance, if you have a missing dependent: destroy.

[dacur]

Relationships lacking a dependent: something:

Item: has_many line_items
Item: has_many inventory_items
Item: has_many barcode_items
DonationSite: has_many donations
StorageLocation: has_many inventory_items
StorageLocation: has_many donations
StorageLocation: has_many distributions
DiaperDriveParticipant has_many donations
Organization has_many adjustments
Organization has_many distributions
Organization has_many donations
Organization has_many donation_sites
Organization has_many diaper_drive_participants
Organization has_many storage_locations
Organization has_many items
Organization has_many partners
Organization has_many transfers
Organization has_many users
Partner has_many distributions
Itemizable has_many line_items

May have missed a few or included some by mistake.

[seanmarcia]

Looks like when Rubocop gets merged in this will be taken care of.

We may want another issue about adding in soft deletes via papertrail or acts_as_paranoid but for now I'm closing this.