-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache the history #35
Comments
@lmerriam check on staging currently it uses cache only if user has enough checkins to cover visible range |
Thanks Max! It seems to be working well, could you clarify exactly what you meant here:
|
If the earliest checkin date is greater than visible start date then API call is preformed again. Same on other edge |
Gotcha, sounds good. One thing I should have been more explicit about: As part of caching I was hoping we could save the user's position and visible trackables in the history. So that if I switch to the check-in, then switch back the the history, I'll return to the same position with the same visible charts and we won't have to reload any data (plus user gets the benefit of not losing their settings) Is this feasible? |
I think it is. |
deployed to staging |
Works fantastic for me! |
Right now, if the user leaves the history to navigate to another section of the app, then returns to the history, they have to load the history again. If possible, it would be ideal to cache the currently visible history when the graph loads, so that the user can quickly switch between sections of the app.
The text was updated successfully, but these errors were encountered: