feat: makes changes to accomodate removing seeding #4220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticspoon
commented
Mar 25, 2024
| @@ -26,7 +26,7 @@ class Kit < ApplicationRecord | |||
| scope :by_partner_key, ->(key) { joins(:items).where(items: { partner_key: key }) } | |||
| scope :by_name, ->(name) { where("name ILIKE ?", "%#{name}%") } | |||
|
|
|||
| validates :organization, :name, presence: true | |||
| validates :name, presence: true | |||
There was a problem hiding this comment.
It belong_to an org, validation feels unneseccary.
There was a problem hiding this comment.
belongs_to used to imply optional - that switched to mandatory by default, so yep, a validation is redundant.
elasticspoon
force-pushed
the
remove-spec-seeding-base-changes
branch
2 times, most recently
from
ef7303c
to
aa72dd5
Compare
Makes changes to factories, models, and rails helper needed to allow removal of seeding. Adds RSpec meta tag seed_items when set to false will disable seeding of items on a per test basis. ENV flag SKIP_SEED=true will prevent rspec seeding before the suite runs.
elasticspoon
force-pushed
the
remove-spec-seeding-base-changes
branch
from
aa72dd5
to
f056d90
Compare
This was referenced Mar 25, 2024
Merged
dorner
requested changes
Mar 26, 2024
| @@ -26,7 +26,7 @@ class Kit < ApplicationRecord | |||
| scope :by_partner_key, ->(key) { joins(:items).where(items: { partner_key: key }) } | |||
| scope :by_name, ->(name) { where("name ILIKE ?", "%#{name}%") } | |||
|
|
|||
| validates :organization, :name, presence: true | |||
| validates :name, presence: true | |||
There was a problem hiding this comment.
belongs_to used to imply optional - that switched to mandatory by default, so yep, a validation is redundant.
dorner
approved these changes
Mar 28, 2024
|
@elasticspoon all looks good to me! Some conflicts though |
|
@dorner fixed (failure is a flake i'm pretty sure) |
|
Nice! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4199
Makes changes to factories, models, and rails helper needed to allow removal of seeding.
Adds RSpec meta tag
seed_itemswhen set tofalsewill disable seeding of items on a per test basis.ENVflagSKIP_SEED=truewill prevent rspec seeding before the suite runs.Note
I added some comments in places because I found stuff confusing. Those can be removed in the final PR but most of them felt like stuff worth bringing up.
Additional note: the speedup was actually much less than I expected, across all the models I saw only a 5s speedup, from 29s to 25s
Type of change
How Has This Been Tested?
Passes all tests