Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very cool tool! A little feedback: #4

Open
Nakilon opened this issue Jul 26, 2022 · 1 comment
Open

Very cool tool! A little feedback: #4

Nakilon opened this issue Jul 26, 2022 · 1 comment

Comments

@Nakilon
Copy link

Nakilon commented Jul 26, 2022

With Gemfile like this:

source "https://rubygems.org"

gem "minitest", github: "Nakilon/minitest", branch: "patch"
gem "minitest-around"
gem "webmock"

gemspec

plugin "bundler-graph"

It produces
image

  1. The [[default]] (and [[development]]) might look better at the top level. I don't remember how exactly to make it in dot, maybe via defining subgraphs. I have spent some time tweaking the dot earlier around a similar tool for Homebrew.
  2. Maybe there is a way to somehow tell the difference and make it visible which gems are defined in Gemfile and which in the .gemspec
  3. On my image there are two arrows to minitest that looks excessive but the reason is that I specify the version of it. Maybe have an option to add the version/ref attached to the edge if defined.
@duckinator
Copy link
Member

wrt 3, I think the two lines leading to minitest makes sense: two things are depending on it, and the graph is indicating that you would have to change two things to remove the dependency.

Aside from that, I agree with what you said. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants