This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
bundle exec shouldn't run Bundler.setup just setting the correct rubyopts options is enough #1598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What kind of performance improvement are you seeing after this change? Do you have any benchmarks? |
… right rubyopts options is enough This makes bundle exec rake environment of this https://gist.github.com/d61b87f53277efd6079e Gemfile, 17% faster
|
The PR is generated from my 1-1-stable branch but I'm pushing it to master. Anyway should go to both branches. No idea what github is doing here :P |
|
@sferik check the commit message I sent a Gemfile that shows a 17% speedup with this change |
|
Merge it, merge it, merge it! |
|
👍 Nice! I'll pull it into master and cherry-pick into 1-1-stable. |
sferik
added a commit
that referenced
this pull request
Dec 21, 2011
bundle exec shouldn't run Bundler.setup just setting the correct rubyopts options is enough
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.