This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Multiple without-group support for bundler list #6939
Closed
zaratan
wants to merge
2
commits into
rubygems:master
from
shotgunsoftware:add_multiple_without_groups_in_list
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,8 +31,16 @@ def run | |
|
||
private | ||
|
||
def without_groups | ||
@without_groups ||= @options["without-group"].split(/\s*,\s*/) | ||
end | ||
|
||
def verify_group_exists(groups) | ||
raise InvalidOption, "`#{@options["without-group"]}` group could not be found." if @options["without-group"] && !groups.include?(@options["without-group"].to_sym) | ||
if @options["without-group"] | ||
without_groups.each do |without_group| | ||
raise InvalidOption, "`#{without_group}` group could not be found." unless groups.include?(without_group.to_sym) | ||
end | ||
end | ||
|
||
raise InvalidOption, "`#{@options["only-group"]}` group could not be found." if @options["only-group"] && !groups.include?(@options["only-group"].to_sym) | ||
end | ||
|
@@ -45,13 +53,14 @@ def filtered_specs_by_groups | |
|
||
show_groups = | ||
if @options["without-group"] | ||
groups.reject {|g| g == @options["without-group"].to_sym } | ||
without_groups.inject(groups) do |memo, without_group| | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure what |
||
memo.reject {|g| g == without_group.to_sym } | ||
end | ||
elsif @options["only-group"] | ||
groups.select {|g| g == @options["only-group"].to_sym } | ||
else | ||
groups | ||
end.map(&:to_sym) | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please don't remove the spacing. It helps with readability. |
||
definition.specs_for(show_groups) | ||
end | ||
end | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how does
a given set of groups
sound instead?