-
-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent changing MFA to ui_only #3084
Conversation
|
Code looks fine, but I think we should add a test as there is some logic added. |
Looking good! Along with tests, it'll be great to add a check in the backend to make sure they aren't updating to |
Added backend code, flash banner, and tests. Had to refactor a bit because of codeclimate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions that should be addressed but otherwise LGTM! Could you also refactor/squash your commits?
Also, I think an update to the guides would be needed 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨ 🚀
@sonalkr132 are we ok with merging and deprecating ui_only
right now (with the only heads up being an update to the guides). I think it would be ok as a small percentage are at this level + we are now recommending ui_and_gem_signin
and ui_and_api
.
🙏 please squash commits before merge |
87edf77
to
fb4ce2d
Compare
Rebased and squashed |
12e694f
to
3bb0b24
Compare
3bb0b24
to
d93365b
Compare
Went with |
Thank you @kevinlinxc |
Addresses the remaining half of #2968 (flash messages already resolved/being resolved)
Hides ui_only option for MFA, unless the user is currently using ui_only, ultimately preventing people from switching to ui_only.
Testing:
MFA set to something else:
Set MFA to ui_only:
Result: