Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate ui_only and migrate users to ui_and_gem_signin #2968

Open
sonalkr132 opened this issue Feb 22, 2022 · 5 comments
Open

Deprecate ui_only and migrate users to ui_and_gem_signin #2968

sonalkr132 opened this issue Feb 22, 2022 · 5 comments
Labels

Comments

@sonalkr132
Copy link
Member

ui_only was added with our limited understanding of expected mfa levels. ui_and_gem_sigin better suits most usecases.
We should remove ui_only from all new mfa changes and show flash message to users with ui_only mfa to migrate to ui_and_gem_sign.
Perhaps at a later point, we should migrate ui_only users to ui_gem_signin automatically.

Is your feature request related to a problem?

ui_only level is not as safe as ui_and_gem_sigin.

Describe the solution you'd like

Remove ui_only level.

Additional context

#2500

@jenshenny
Copy link
Member

#2994 adds a warning and redirects the user to the edit settings page if they have UI only enabled and is a MFA recommended user upon login. What do you think of removing the MFA recommended requirement and redirect + display a flash message for all accounts with UI only?

Screen Shot 2022-03-24 at 10 30 05 PM

@sonalkr132
Copy link
Member Author

What do you think of removing the MFA recommended requirement and redirect + display a flash message for all accounts with UI only?

Should be fine.

We should remove ui_only from all new mfa changes

We should also get this done sooner than later. More users who end up choosing ui_only, more users we have to migrate and annoy.

@sonalkr132
Copy link
Member Author

Only item pending here is announcement that we will be migrating all ui_only to ui_and_gem_signin. A small blog post with whats being changed and why should do. After a month or so, we will migrate all ui_only to ui_and_gem_signin.

@jenshenny
Copy link
Member

The blog post has been merged, a migration still needs to be created to run on Sept 22 to move users from ui_only to ui_and_gem_signin. I'll jump on this if no one else is interested :)

@jenshenny
Copy link
Member

Adding an update for this. The rake task to migrate all the users on the UI_only to the UI_and_gem_signin level was run on Sept 22. Theoretically there should be no one of the UI only level anymore.

The last step to complete this migration would be to remove UI only from the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants