Comment out Gittip link on gem pages #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't yet have the landing pages on the Gittip side needed to support
the level of indirection to show Gittip accounts associated with a Ruby
gem:
gratipay/gratipay.com#1591
This comments out the link from gem pages for now. The link from
profile pages on Rubygems to Gittip is fine.
|
Note that this is untested. |
|
And this is prompted by this link having been released: |
|
This needs to get merged and deployed. @sferik |
|
This seems the best way to fix it if someone's tested it out. My ruby gems environment is way out of date, so I can't test it as easily as anyone more active on the project. 👍 |
|
Can this please get merged? This is linking to non-existing Gittip pages |
indirect
added a commit
that referenced
this pull request
Jan 6, 2014
Comment out Gittip link on gem pages
|
Thanks for merging this @indirect. There's definitely still interest in Rubygems integration, but Gittip isn't quite ready. |
|
Don't mean to keep pestering, but it doesn't look like this has been deployed: https://rubygems.org/gems/activeadmin |
|
@seanlinsley Should be fixed now! |
|
yep, thanks 🐱 |
indirect
added a commit
that referenced
this pull request
Jan 29, 2015
Comment out Gittip link on gem pages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't yet have the landing pages on the Gittip side needed to support
the level of indirection to show Gittip accounts associated with a Ruby
gem:
This comments out the link from gem pages for now. The link from
profile pages on Rubygems to Gittip is fine.