Fix gem metadata when using aliases #894
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
After we upgraded our yaml parser to
Psych
latest, and start usingsafe_load
, the YAML aliases on the metadata file stop working, they were been rejected by rubygems.org.Solution
On
safe_load
we need to pass atrue
flag to allow aliases.I added a regression test to make sure this doesnt happen again,
aliases-0.0.0.gem
is pretty much a test gem with one dependency like this (which includes a&id001
alias):review @evanphx @qrush @dwradcliffe @sferik
cc @tenderlove