Load new gems for index update. #234
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! Do you have a test to balance this code change? |
|
Tried to account for it by dumping the specifications that were already loaded. Not sure if there's a better way to get them to the state they are in when gem generated_index is run from the cli - at that point it seems like Gem::Specifications contains the locally installed gems. |
ghost
assigned 
|
Your new code in the tests actually change things just like the code in the implementation. You need to be testing that a gem only located on in the specs array was indexed. |
|
Ugh sorry, not sure why I thought that was sufficient. Going to take another run at this issue shortly. |
|
You'll need to add the specs too, see the second patch of issue #264 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Issue #232