Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate stats to otel #2989

Merged
merged 1 commit into from
Mar 6, 2023
Merged

chore: migrate stats to otel #2989

merged 1 commit into from
Mar 6, 2023

Conversation

fracasula
Copy link
Collaborator

Copy of #2795

Will merge after we successfully migrate Statsd summaries to histograms.

@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Patch coverage: 81.35% and project coverage change: +0.24 🎉

Comparison is base (1b6af85) 53.09% compared to head (6a831a4) 53.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2989      +/-   ##
==========================================
+ Coverage   53.09%   53.34%   +0.24%     
==========================================
  Files         332      342      +10     
  Lines       52350    52884     +534     
==========================================
+ Hits        27794    28209     +415     
- Misses      22956    23051      +95     
- Partials     1600     1624      +24     
Impacted Files Coverage Δ
app/apphandlers/gatewayAppHandler.go 13.82% <ø> (ø)
app/apphandlers/setup.go 73.25% <ø> (ø)
gateway/internal/stats/stats.go 100.00% <ø> (ø)
jobsdb/admin.go 68.99% <0.00%> (ø)
runner/runner.go 69.66% <50.00%> (-0.61%) ⬇️
services/metric/registry.go 82.25% <50.00%> (-0.15%) ⬇️
testhelper/stats/prometheus.go 57.14% <57.14%> (ø)
regulation-worker/cmd/main.go 71.95% <62.50%> (-1.39%) ⬇️
services/stats/otel.go 73.00% <73.00%> (ø)
services/stats/statsd_measurement.go 75.55% <75.55%> (ø)
... and 22 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fracasula fracasula force-pushed the chore.otel branch 2 times, most recently from 3921295 to 4c60195 Compare February 17, 2023 13:28
@fracasula fracasula changed the title [DO NOT MERGE] chore: migrate stats to otel chore: migrate stats to otel Feb 17, 2023
@fracasula fracasula force-pushed the chore.otel branch 3 times, most recently from efb611b to a766a80 Compare February 23, 2023 10:45
@fracasula fracasula force-pushed the chore.otel branch 4 times, most recently from 54733fe to 4ae6abc Compare March 2, 2023 19:07
@fracasula fracasula marked this pull request as ready for review March 6, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants