feat(gateway): support new event type extract #2999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er into feat/extractevent
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2999 +/- ##
==========================================
+ Coverage 53.43% 53.60% +0.17%
==========================================
Files 342 346 +4
Lines 52747 53627 +880
==========================================
+ Hits 28185 28747 +562
- Misses 22947 23248 +301
- Partials 1615 1632 +17
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
fracasula
requested changes
Feb 27, 2023
fracasula
requested changes
Mar 2, 2023
fracasula
approved these changes
Mar 9, 2023
nidhilashkari17
approved these changes
Mar 9, 2023
atzoum
reviewed
Mar 14, 2023
| @@ -1256,6 +1269,9 @@ func (gateway *HandleT) StartWebHandler(ctx context.Context) error { | |||
| srvMux.HandleFunc("/version", WithContentType("application/json; charset=utf-8", gateway.versionHandler)).Methods("GET") | |||
| srvMux.HandleFunc("/robots.txt", gateway.robots).Methods("GET") | |||
|
|
|||
| // internal endpoints | |||
| internalMux.HandleFunc("/v1/extract", gateway.webExtractHandler).Methods("POST") | |||
There was a problem hiding this comment.
@cisse21 doesn't this require proxy adaptations too so that not a random node is picked?
This was referenced Mar 16, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of supporting a new event type,
extract, we are addinga new endpoint
/internal/extractfor ingesting the event.We are not enforcing the event payload to have either userId or anonymousId.
The same is reflected in the test case modification.
Notion Ticket
https://www.notion.so/rudderstacks/Development-New-event-for-extract-b9e4d7abef294bd7a690acc0332a18ea?pvs=4
Security