Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: debugger's badgerdb cache optimisations #3042

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

atzoum
Copy link
Contributor

@atzoum atzoum commented Feb 27, 2023

Description

  • Using multiple versions of the same key instead of a single version of each key containing multiple values (less cpu, i/o & memory intensive)
  • Getting rid of mutexes (non-blocking between competing goroutines, e.g. router or gateway workers operating on the same keys)
  • Delete previous values after reading them from cache

Notion Ticket

Link

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@atzoum atzoum changed the title chore: optimise debugger badgerdb cache chore: optimise debugger's badgerdb cache Feb 27, 2023
@atzoum atzoum changed the title chore: optimise debugger's badgerdb cache chore: debugger's badgerdb cache optimizations Feb 27, 2023
@atzoum atzoum changed the title chore: debugger's badgerdb cache optimizations chore: debugger's badgerdb cache optimisations Feb 27, 2023
@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Base: 52.85% // Head: 52.85% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (d1af6fd) compared to base (a1c4ab8).
Patch coverage: 97.56% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff               @@
##           release/1.6.x    #3042   +/-   ##
==============================================
  Coverage          52.85%   52.85%           
==============================================
  Files                338      338           
  Lines              52136    52120   -16     
==============================================
- Hits               27555    27547    -8     
+ Misses             22972    22966    -6     
+ Partials            1609     1607    -2     
Impacted Files Coverage Δ
services/debugger/cache/internal/badger/badger.go 76.99% <97.56%> (+3.34%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@atzoum atzoum force-pushed the chore.badgerTuning branch 3 times, most recently from 16c41f7 to 871619a Compare February 27, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants