Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove workerID tag #3055

Merged
merged 1 commit into from
Mar 1, 2023
Merged

chore: remove workerID tag #3055

merged 1 commit into from
Mar 1, 2023

Conversation

cisse21
Copy link
Member

@cisse21 cisse21 commented Feb 28, 2023

Description

Remove workerID tag to reduce the number of Prometheus time series

Notion Ticket

Notion Link

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@cisse21 cisse21 marked this pull request as ready for review February 28, 2023 23:24
@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.16 ⚠️

Comparison is base (828f70d) 52.79% compared to head (a0977ca) 52.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3055      +/-   ##
==========================================
- Coverage   52.79%   52.64%   -0.16%     
==========================================
  Files         334      334              
  Lines       52202    52198       -4     
==========================================
- Hits        27562    27481      -81     
- Misses      23043    23121      +78     
+ Partials     1597     1596       -1     
Impacted Files Coverage Δ
gateway/gateway.go 76.39% <100.00%> (-0.10%) ⬇️
processor/stash/stash.go 45.25% <0.00%> (-21.54%) ⬇️
router/manager/manager.go 96.70% <0.00%> (-3.30%) ⬇️
jobsdb/migration.go 76.28% <0.00%> (-1.29%) ⬇️
processor/processor.go 86.79% <0.00%> (-0.41%) ⬇️
jobsdb/backup.go 75.40% <0.00%> (-0.36%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants