Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(jobsdb): omit workspaceId tag when it doesn't correspond to an actual workspace #3057

Merged
merged 2 commits into from
Mar 1, 2023

Conversation

atzoum
Copy link
Contributor

@atzoum atzoum commented Mar 1, 2023

Description

Not including a workspaceId tag in jobsdb metrics when its value is empty or _all_

Notion Ticket

Link

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.04 ⚠️

Comparison is base (e57362e) 52.65% compared to head (35eef2f) 52.62%.

❗ Current head 35eef2f differs from pull request most recent head b56a083. Consider uploading reports for the commit b56a083 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3057      +/-   ##
==========================================
- Coverage   52.65%   52.62%   -0.04%     
==========================================
  Files         334      334              
  Lines       52198    52195       -3     
==========================================
- Hits        27486    27467      -19     
- Misses      23117    23129      +12     
- Partials     1595     1599       +4     
Impacted Files Coverage Δ
services/metric/measurement.go 100.00% <ø> (ø)
jobsdb/jobsdb_utils.go 78.76% <100.00%> (-0.29%) ⬇️
jobsdb/migration.go 73.96% <0.00%> (-2.32%) ⬇️
processor/processor.go 86.79% <0.00%> (-0.57%) ⬇️
services/rsources/handler.go 74.65% <0.00%> (+0.82%) ⬆️
testhelper/log/log.go 11.53% <0.00%> (+3.84%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@atzoum atzoum force-pushed the chore.jobsdbMetrics branch 2 times, most recently from 3a7961c to fac1017 Compare March 1, 2023 11:59
@cisse21 cisse21 changed the base branch from master to release/1.6.x March 1, 2023 13:24
@cisse21 cisse21 changed the base branch from release/1.6.x to master March 1, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants