chore(warehouse): naming conventions

[achettyiitr]

Description

• Removing suffix T from struct types.
• Removing suffix I from interface types.
• Replace map[string]string with warehouseutils.TableSchema
• Replace map[string]map[string]string with warehouseutils.Schema
• Move Schema and TableSchema to the model package. 4e8f72c
• Deepsource changes
  1. Possibly return is missed after the http.Error call
  2. Use %q to quote a string in fmt.Sprintf format specifiers
  3. Unnecessary block

Notion Ticket

https://www.notion.so/rudderstacks/clean-code-3f197f00beac4fe3917385af011c2902?pvs=4

Security

• The code changed/added as part of this pull request won't create any security issues with how the software is being used.

[codecov]

Codecov Report

Patch coverage: 31.30% and project coverage change: -0.01 ⚠️

Comparison is base (d3320fa) 53.60% compared to head (ad9ecf6) 53.59%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3076      +/-   ##
==========================================
- Coverage   53.60%   53.59%   -0.01%     
==========================================
  Files         346      347       +1     
  Lines       53805    53806       +1     
==========================================
- Hits        28840    28836       -4     
- Misses      23328    23333       +5     
  Partials     1637     1637              

Impacted Files	Coverage Δ
services/pgnotifier/pgnotifier.go	2.83% <0.00%> (ø)
warehouse/admin.go	3.17% <0.00%> (ø)
warehouse/identities.go	1.04% <0.00%> (ø)
warehouse/identity/identity.go	0.51% <ø> (ø)
...ehouse/integrations/azure-synapse/azure-synapse.go	0.31% <0.00%> (ø)
warehouse/integrations/datalake/datalake.go	6.77% <0.00%> (ø)
warehouse/integrations/manager/manager.go	51.19% <ø> (ø)
warehouse/integrations/mssql/mssql.go	1.62% <0.00%> (ø)
warehouse/integrations/postgres/diagnostic.go	88.46% <ø> (ø)
warehouse/integrations/postgres/postgres.go	0.53% <0.00%> (ø)
... and 38 more

... and 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[lvrach]

Could we move tableSchema under the model package?

[achettyiitr]

Could we move tableSchema under the model package?

• Yes. This required me to move Warehouse and Schema as well into the model's package because of circular dependency. 4e8f72c