Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use token on protoc setup to avoid rate-limit #3083

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

lvrach
Copy link
Member

@lvrach lvrach commented Mar 8, 2023

Description

Our CI checks sometimes fails with the following error:
Screenshot 2023-03-08 at 12 41 58 PM

As suggested by setup-protoc's README, the following option can be used to avoid rate-limit:

  with:
    repo-token: ${{ secrets.GITHUB_TOKEN }}

Notion Ticket

https://www.notion.so/rudderstacks/Fix-CI-setup-protoc-rate-limit-90e1c06be0464184bb6aaf7e53e3fade?pvs=4

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@lvrach lvrach marked this pull request as ready for review March 8, 2023 11:49
@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.08 ⚠️

Comparison is base (f128b93) 53.52% compared to head (55d180c) 53.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3083      +/-   ##
==========================================
- Coverage   53.52%   53.44%   -0.08%     
==========================================
  Files         342      342              
  Lines       52738    52738              
==========================================
- Hits        28228    28187      -41     
- Misses      22893    22939      +46     
+ Partials     1617     1612       -5     
Impacted Files Coverage Δ
processor/stash/stash.go 45.25% <0.00%> (-21.54%) ⬇️
testhelper/log/log.go 7.69% <0.00%> (-3.85%) ⬇️
services/rsources/handler.go 73.82% <0.00%> (-1.38%) ⬇️
jobsdb/migration.go 77.06% <0.00%> (-0.52%) ⬇️
jobsdb/backup.go 75.40% <0.00%> (-0.36%) ⬇️
processor/processor.go 87.35% <0.00%> (+0.15%) ⬆️
router/router.go 77.86% <0.00%> (+0.19%) ⬆️
...rprise/suppress-user/internal/badgerdb/badgerdb.go 83.50% <0.00%> (+0.50%) ⬆️
utils/logger/nop.go 63.15% <0.00%> (+5.26%) ⬆️
services/stats/statsd.go 90.80% <0.00%> (+11.49%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lvrach lvrach requested review from a team, fracasula and raman2805 and removed request for a team March 8, 2023 12:09
@lvrach lvrach merged commit 0f89b26 into master Mar 8, 2023
@lvrach lvrach deleted the chore.protoc-ratelimit branch March 8, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants