Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix namespace bug #3110

Merged
merged 4 commits into from
Mar 17, 2023
Merged

chore: fix namespace bug #3110

merged 4 commits into from
Mar 17, 2023

Conversation

cisse21
Copy link
Member

@cisse21 cisse21 commented Mar 17, 2023

Description

Fixing the bug introduced in the previous refactoring of getNamespace function which returned an empty namespace even though there was a valid namespace present in the schema table also adding tests for the same

Notion Ticket

Notion Link

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@cisse21 cisse21 marked this pull request as ready for review March 17, 2023 08:37
@cisse21 cisse21 changed the base branch from master to prerelease/1.7.0-rc.1 March 17, 2023 08:38
@cisse21 cisse21 changed the base branch from prerelease/1.7.0-rc.1 to master March 17, 2023 08:38
@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Patch coverage: 86.66% and project coverage change: +0.22 🎉

Comparison is base (0d9af35) 53.55% compared to head (e5dac9d) 53.78%.

Additional details and impacted files
@@                Coverage Diff                @@
##           release/1.7.x    #3110      +/-   ##
=================================================
+ Coverage          53.55%   53.78%   +0.22%     
=================================================
  Files                350      350              
  Lines              54452    54456       +4     
=================================================
+ Hits               29163    29287     +124     
+ Misses             23633    23506     -127     
- Partials            1656     1663       +7     
Impacted Files Coverage Δ
warehouse/warehouse.go 13.44% <86.66%> (+1.85%) ⬆️

... and 9 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lvrach
Copy link
Member

lvrach commented Mar 17, 2023

Please provide more context, what is the bug and the intended fix.

@cisse21
Copy link
Member Author

cisse21 commented Mar 17, 2023

Please provide more context, what is the bug and the intended fix.

Updated the description now

@cisse21 cisse21 changed the base branch from master to release/1.7.x March 17, 2023 09:21
@cisse21 cisse21 merged commit 7b6fa35 into release/1.7.x Mar 17, 2023
@cisse21 cisse21 deleted the chore.fixNamespaceBug branch March 17, 2023 09:29
cisse21 added a commit that referenced this pull request Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants