Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: marketo bulk upload edits #3778

Merged
merged 13 commits into from
Aug 28, 2023
Merged

fix: marketo bulk upload edits #3778

merged 13 commits into from
Aug 28, 2023

Conversation

shrouti1507
Copy link
Contributor

@shrouti1507 shrouti1507 commented Aug 23, 2023

Description

resolves INT-157
Fresh PR raised on the basis of #3719

Linear Ticket

< Linear Link >

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.14% ⚠️

Comparison is base (2fc1389) 69.17% compared to head (b843fc9) 69.03%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3778      +/-   ##
==========================================
- Coverage   69.17%   69.03%   -0.14%     
==========================================
  Files         347      347              
  Lines       51684    51753      +69     
==========================================
- Hits        35751    35727      -24     
- Misses      13640    13727      +87     
- Partials     2293     2299       +6     
Files Changed Coverage Δ
...tchrouter/asyncdestinationmanager/common/common.go 41.17% <ø> (ø)
...onmanager/marketo-bulk-upload/marketobulkupload.go 0.00% <0.00%> (ø)
router/batchrouter/handle_async.go 0.00% <0.00%> (ø)

... and 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Chandra shekar Varkala and others added 6 commits August 25, 2023 12:23
…/marketobulkupload.go

Co-authored-by: Leonidas Vrachnis <leo.al.vra@gmail.com>
…/marketobulkupload.go

Co-authored-by: Leonidas Vrachnis <leo.al.vra@gmail.com>
…/marketobulkupload.go

Co-authored-by: Leonidas Vrachnis <leo.al.vra@gmail.com>
…/marketobulkupload.go

Co-authored-by: Leonidas Vrachnis <leo.al.vra@gmail.com>
@chandumlg chandumlg merged commit 94df125 into master Aug 28, 2023
31 checks passed
@chandumlg chandumlg deleted the fix.mb-upload branch August 28, 2023 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants