-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: marketo bulk upload edits #3778
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #3778 +/- ##
==========================================
- Coverage 69.17% 69.03% -0.14%
==========================================
Files 347 347
Lines 51684 51753 +69
==========================================
- Hits 35751 35727 -24
- Misses 13640 13727 +87
- Partials 2293 2299 +6
☔ View full report in Codecov by Sentry. |
koladilip
reviewed
Aug 25, 2023
router/batchrouter/asyncdestinationmanager/marketo-bulk-upload/marketobulkupload.go
Outdated
Show resolved
Hide resolved
router/batchrouter/asyncdestinationmanager/marketo-bulk-upload/marketobulkupload.go
Outdated
Show resolved
Hide resolved
koladilip
reviewed
Aug 25, 2023
router/batchrouter/asyncdestinationmanager/marketo-bulk-upload/marketobulkupload.go
Show resolved
Hide resolved
lvrach
reviewed
Aug 25, 2023
router/batchrouter/asyncdestinationmanager/marketo-bulk-upload/marketobulkupload.go
Outdated
Show resolved
Hide resolved
router/batchrouter/asyncdestinationmanager/marketo-bulk-upload/marketobulkupload.go
Outdated
Show resolved
Hide resolved
lvrach
approved these changes
Aug 25, 2023
router/batchrouter/asyncdestinationmanager/marketo-bulk-upload/marketobulkupload.go
Outdated
Show resolved
Hide resolved
router/batchrouter/asyncdestinationmanager/marketo-bulk-upload/marketobulkupload.go
Outdated
Show resolved
Hide resolved
fracasula
approved these changes
Aug 25, 2023
…/marketobulkupload.go Co-authored-by: Leonidas Vrachnis <leo.al.vra@gmail.com>
…/marketobulkupload.go Co-authored-by: Leonidas Vrachnis <leo.al.vra@gmail.com>
…/marketobulkupload.go Co-authored-by: Leonidas Vrachnis <leo.al.vra@gmail.com>
…/marketobulkupload.go Co-authored-by: Leonidas Vrachnis <leo.al.vra@gmail.com>
chandumlg
approved these changes
Aug 25, 2023
This was referenced Aug 28, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
resolves INT-157
Fresh PR raised on the basis of #3719
Linear Ticket
< Linear Link >
Security