feat: snowflake appendmode #3745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3745 +/- ##
==========================================
+ Coverage 68.69% 68.73% +0.03%
==========================================
Files 345 345
Lines 51652 51601 -51
==========================================
- Hits 35484 35468 -16
+ Misses 13881 13846 -35
Partials 2287 2287
☔ View full report in Codecov by Sentry. |
fracasula
force-pushed
the
feat.pipe-108
branch
2 times, most recently
from
32c8b92
to
9712623
Compare
achettyiitr
reviewed
Aug 17, 2023
fracasula
force-pushed
the
feat.pipe-108
branch
from
0322792
to
1a0fc96
Compare
fracasula
commented
Aug 17, 2023
fracasula
force-pushed
the
feat.pipe-108
branch
from
f2cbf42
to
c511406
Compare
achettyiitr
reviewed
Aug 21, 2023
Comment on lines
314
to
323
| logFields := []interface{}{ | ||
| lf.SourceID, sf.Warehouse.Source.ID, | ||
| lf.SourceType, sf.Warehouse.Source.SourceDefinition.Name, | ||
| lf.DestinationID, sf.Warehouse.Destination.ID, | ||
| lf.DestinationType, sf.Warehouse.Destination.DestinationDefinition.Name, | ||
| lf.WorkspaceID, sf.Warehouse.WorkspaceID, | ||
| lf.Namespace, sf.Namespace, | ||
| lf.TableName, tableName, | ||
| lf.LoadTableStrategy, sf.config.loadTableStrategy, | ||
| } |
There was a problem hiding this comment.
❤️ It definitely cleaned up a lot of duplicate code.
achettyiitr
reviewed
Aug 23, 2023
achettyiitr
approved these changes
Aug 23, 2023
1 task
This was referenced Aug 25, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding
APPENDmode for Snowflake.Changelog
MERGE INTOqueryloadTableStrategyfeature flagAPPENDsupport toLoadTablewith integration testsAPPENDsupport toLoadUserTableswith integration testsLinear Ticket
< Linear Link >
Security