Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decide to merge or separate all mod variants #11

Closed
Rudxain opened this issue Apr 11, 2022 · 3 comments
Closed

Decide to merge or separate all mod variants #11

Rudxain opened this issue Apr 11, 2022 · 3 comments
Labels
question Further information is requested refactoring Better use of paradigms and patterns, also simplification

Comments

@Rudxain
Copy link
Owner

Rudxain commented Apr 11, 2022 •
edited
Loading

I don't know whether modulo fns should have a param to select a variant, or if each variant should have its own independent function. The JS trend seems to be that they should be separated.

Related
@Rudxain Rudxain added question Further information is requested refactoring Better use of paradigms and patterns, also simplification labels Apr 11, 2022
@Rudxain
Copy link
Owner Author

Rudxain commented Jun 3, 2022

For my personal library, they will be merged into 1 function, but for JS they will be separated

@Rudxain
Copy link
Owner Author

Rudxain commented Jul 16, 2022

Both libs have been merged, so this is my "personal lib" now.

@Rudxain
Copy link
Owner Author

Rudxain commented Nov 7, 2022

These will be moved to polyfills

#32

@Rudxain Rudxain closed this as not planned Won't fix, can't repro, duplicate, stale Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested refactoring Better use of paradigms and patterns, also simplification
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Rudxain