Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add commit ID to version info #574

Closed
ousia opened this issue May 12, 2020 · 2 comments
Closed

Add commit ID to version info #574

ousia opened this issue May 12, 2020 · 2 comments
Labels
A-desktop Area: Desktop Application A-web Area: Web & Extensions
Milestone
v0.1.0 (Initial r...

Comments

@ousia
Copy link
Contributor

ousia commented May 12, 2020

When asking for version number, I get with latest nightly build:

$ ./ruffle --version
basic 0.1.0

How about the following scheme?

0.1.0-basic-fe4676a

I mean, standard version number, status (such as basic, stable or devel) and commit.

This would also make bug reporting easier.

Just in case it helps.
@Herschel Herschel added A-desktop Area: Desktop Application A-web Area: Web & Extensions labels May 12, 2020
@Dinnerbone Dinnerbone mentioned this issue May 12, 2020
Open
@Justin-CB
Copy link
Contributor

"basic" should probably just be "ruffle" or "ruffle_player". I would like the version number to be something like 0.1.0-stable, 0.1.0-nightly-date, or 0.1.0-git-commit.

@Herschel Herschel mentioned this issue Aug 5, 2020
Merged
@Herschel Herschel added this to the v0.1.0 (Initial release) milestone Nov 4, 2020
@Herschel Herschel changed the title more explicit version numbering? Add commit ID to version info Nov 4, 2020
@Herschel
Copy link
Member

Herschel commented Nov 5, 2020

Implemented on web in #1495.

@Herschel Herschel closed this as completed Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-desktop Area: Desktop Application A-web Area: Web & Extensions
Projects
None yet
Milestone
v0.1.0 (Initial release)
Development

No branches or pull requests
3 participants
@Herschel @ousia @Justin-CB