Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database of the sources documents (i.e. ENB publications) #1

Closed
rufuspollock opened this issue Dec 2, 2015 · 10 comments
Closed

Database of the sources documents (i.e. ENB publications) #1

rufuspollock opened this issue Dec 2, 2015 · 10 comments

Comments

@rufuspollock
Copy link
Owner

Store at: data/documents.csv

What is wanted:

Do we already have this?

If not we can sort of get it from the txt files we have.

/cc @tommv

@rufuspollock rufuspollock changed the title Database of the sources documents (i.e. ENB issues) Database of the sources documents (i.e. ENB publications) Dec 2, 2015
@tommv
Copy link
Collaborator

tommv commented Dec 3, 2015

Yes we do have them:

This was referenced Dec 3, 2015
@rufuspollock
Copy link
Owner Author

@pauloborges for this and the #14 (DB of events) we may just want to rescrape http://www.iisd.ca/enb/vol12/ as we get much more info e.g. issue no.

@pauloborges
Copy link
Collaborator

Just pushed this change. Check the script and both databases.

@rufuspollock
Copy link
Owner Author

@pauloborges looks good. Some quick comments:

  • documents.csv
    • date column value is sometimes summary - that can't be right ...
    • I suggest document id is the file name with extension stripped - that way it corresponds to documents with have stored
  • events.csv
    • suggest renaming name to title in column names
    • could we have title in the last column so stuff is more readable
  • can we get a datapackage.json with those CSVs in it and description for columns. BTW https://github.com/okfn/dpm is your friend here ;-)

@pauloborges
Copy link
Collaborator

@rgrp,

Every event has one issue that is a summary of the event. It has no associated date, as you can see in the original page. What should I put as its value?

@pauloborges
Copy link
Collaborator

I've done the other suggested modifications, including adding a datapackage.json file. You can check it using the Data Package Viewer.

Please check the columns descriptions since my english isn't very good.

@rufuspollock
Copy link
Owner Author

@pauloborges i would put the date as the last day of the event.

@pauloborges
Copy link
Collaborator

@rgrp, ok! I'll change this as soon as possible.

@pauloborges
Copy link
Collaborator

@rgrp, done!

@rufuspollock
Copy link
Owner Author

FIXED.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants