Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S2C_CHALLENGE sends wrong bytes with Async #17

Open
Glitchvid opened this issue Apr 11, 2023 · 0 comments
Open

S2C_CHALLENGE sends wrong bytes with Async #17

Glitchvid opened this issue Apr 11, 2023 · 0 comments

Comments

@Glitchvid
Copy link

When using an Async A2S client and having multiple futures in-flight (using buffered_unordered), any S2C_CHALLENGE responses will just use the most recent challenge bytes received from any server, sending the wrong response.

Client -> b'T' -> Server α
Server α -> b'A' [bytes α] -> Client
Client -> b'T' [bytes α] -> Server β
Server β -> b'A' [bytes β] -> Client
Client -> b'T' [bytes β] -> Server α
etc...

Currently I'm getting around this by having a client pool and using each client exclusively for each buffered_unordered batch; which isn't ideal since the API design allows and encourages using a shared client to make concurrent A2S requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant