Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Readme to reflect custom events #38

Closed
tamb opened this issue Aug 28, 2020 · 3 comments · Fixed by #40
Closed

Update Readme to reflect custom events #38

tamb opened this issue Aug 28, 2020 · 3 comments · Fixed by #40
Assignees

Comments

@tamb
Copy link
Contributor

tamb commented Aug 28, 2020

Current custom events should be added to API section.

I propose we define the structure for docs like:

API

  • Hook 1

  • Custom Event 1

  • Hook 2

  • Custom Event 2

@rumkin
Copy link
Owner

rumkin commented Aug 28, 2020

I think the standard here is to add Events section into the API's and to add links to events into hooks and vice versa. Like MDN does (example HTMLFormElement).

@tamb
Copy link
Contributor Author

tamb commented Aug 31, 2020

@rumkin Gotcha. So a separate section but hooks and events should link to each other. 👍

@rumkin rumkin self-assigned this Sep 1, 2020
@rumkin rumkin linked a pull request Sep 9, 2020 that will close this issue
3 tasks
@rumkin
Copy link
Owner

rumkin commented Sep 9, 2020

This is a proposal from #32 issue. To restructure documentation originally provided by @tamb:

I believe the API sections needs to be restructured as such:

API

Hooks

pillOptions.onReady() etc...

Custom Events (when merged)


And it might look like so:

I believe the API sections needs to be restructured as such:


API

Hooks

onReady() Hook

(ref to pill:ready event)

Events

pill:ready Event

(ref to onReady() hook)

Options

PillOptions.onReady()

Option description.

(ref to onReady() hook)


  • – Sections Hooks, Events and Options could follow in other order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants