Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: post GitHub plan comments with output as a gist #1889

Closed
dmathieu opened this issue Nov 10, 2021 · 2 comments
Closed

Proposal: post GitHub plan comments with output as a gist #1889

dmathieu opened this issue Nov 10, 2021 · 2 comments
Labels
feature New functionality/enhancement help wanted Good feature for contributors

Comments

@dmathieu
Copy link

Hi,

Some of our changes generate quite large plan output (due to other issues with one of our Terraform providers), generating a lot of GitHub comments (up to 50), making the Pull Requests impossible to read.
Ideally, the plan output should be set as an attachment on the comment so it's not limited on size. But the GitHub API doesn't allow setting attachments programmatically.

So here is my proposal: instead of adding the output as text in the comment, create a secret gist for that output, and provide a link to it.
If this change is deemed reasonable, I'm happy to implement it. I'm also happy to hear any alternative.

@jamengual jamengual reopened this Oct 27, 2022
@jamengual jamengual added feature New functionality/enhancement help wanted Good feature for contributors labels Oct 27, 2022
@nitrocode
Copy link
Member

@dmathieu Interesting idea. I think implementing the checks api on the bot would have more return since each plan would be its own clickable section.

#936

What do you think?

@nitrocode
Copy link
Member

Closing this in favor of #936

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality/enhancement help wanted Good feature for contributors
Projects
None yet
Development

No branches or pull requests

3 participants