Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Elm 0.16 #4

Closed
ccapndave opened this issue Nov 19, 2015 · 4 comments
Closed

Support Elm 0.16 #4

ccapndave opened this issue Nov 19, 2015 · 4 comments

Comments

@ccapndave
Copy link

Elm 0.16 now has some color codes in the results from the compiler which either need to be stripped out or (even better!) colored in inline.

Here is an example of some 0.16 output with the current version of the plugin:

The type annotation for `update` does not match its definition.
The type annotation is saying:

    Action
    -> { ..., �[33musername�[0m : ... }
    -> ( { ..., �[33musername�[0m : ... }, Effects.Effects �[33ma�[0m )

But I am inferring that the definition has this type:

    Action
    -> { a | ..., �[33musernames�[0m : ... }
    -> ( { a | ..., �[33musernames�[0m : ... }, Effects.Effects �[33mb�[0m )

�[4mHint�[0m: I compared the record fields and found some potential typos.

    �[33musername�[0m <-> �[33musernames�[0m
@rundis
Copy link
Owner

rundis commented Nov 20, 2015

Should be fixed in 0.1.2 just out. Opted for the simple stripping out approach for now. Couldn't find an easy route to replicate the colouring on the command-line in LT using the primitives available.

@ccapndave
Copy link
Author

I just updated through Lighttable plugin manager, but am getting this error. I am totally new to Lighttable btw, so apologies if this is my fault for updating incorrectly:

ReferenceError: React is not defined
    at component (/Users/dave/Library/Application%20Support/LightTable/plugins/elm_light/elm-light_compiled.js:81:75)
    at eval (/Users/dave/Library/Application%20Support/LightTable/plugins/elm_light/elm-light_compiled.js:8664:68)
    at eval (native)
    at c (file:///Applications/LightTable.app/Contents/Resources/app/core/node_modules/lighttable/bootstrap.js:21542:41)
    at a (file:///Applications/LightTable.app/Contents/Resources/app/core/node_modules/lighttable/bootstrap.js:21550:18)
    at Function.lt.objs.plugins.__BEH__load_js (file:///Applications/LightTable.app/Contents/Resources/app/core/node_modules/lighttable/bootstrap.js:30076:33)
    at c (file:///Applications/LightTable.app/Contents/Resources/app/core/node_modules/lighttable/bootstrap.js:6196:14)
    at a (file:///Applications/LightTable.app/Contents/Resources/app/core/node_modules/lighttable/bootstrap.js:6236:18)
    at c (file:///Applications/LightTable.app/Contents/Resources/app/core/node_modules/lighttable/bootstrap.js:20443:76)
    at a (file:///Applications/LightTable.app/Contents/Resources/app/core/node_modules/lighttable/bootstrap.js:20477:18)

@rundis
Copy link
Owner

rundis commented Nov 20, 2015

DOH !

My bad, forgot to include react.js (worked on my machine because I have another plugin that already loads react). I've published a bugfix release 0.1.3.

@ccapndave
Copy link
Author

Yay, it works perfectly. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants