feat: Add BindMount handler for Linux #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pendo324
reviewed
Oct 2, 2024
chews93319
force-pushed
the
nativeBindMountHandler
branch
from
ca3c2e2
to
6f4f775
Compare
Add handleBindMount to remove consistency entity\nRevise comments for linting and clarity Signed-off-by: Sam Chew <stchew@amazon.com>
chews93319
force-pushed
the
nativeBindMountHandler
branch
from
6f4f775
to
7ee2071
Compare
pendo324
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add handleBindMount to remove consistency entity
Revise comments for linting and clarity
Issue #, if available: #387
Description of changes:
When using DevContainers on Finch within Linux, the operating specific handleBindMounts will remove the "consistency" entity from the argument set.
Testing done:
draft PR Github CI Tests.
I've reviewed the guidance in CONTRIBUTING.md
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.