Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): Bump golang.org/x/tools from 0.11.1 to 0.12.0 #523

Merged
merged 1 commit into from
Aug 14, 2023
Merged

build(deps): Bump golang.org/x/tools from 0.11.1 to 0.12.0 #523

merged 1 commit into from
Aug 14, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 7, 2023 •
edited
Loading

Bumps golang.org/x/tools from 0.11.1 to 0.12.0.

Release notes

Sourced from golang.org/x/tools's releases.

gopls/v0.12.0

This release contains a major rewrite of the way gopls computes and stores package information, with the goal of reducing memory usage and allowing gopls to scale to larger repositories. This change can also significantly reduce startup time when workspaces are reopened, as gopls now uses a file-based cache to persist data across sessions. With these optimizations, gopls is finally able to fully analyze dependencies using the golang.org/x/tools/go/analysis framework, resulting in improved accuracy for analysis diagnostics.

You can install this release with go install:

go install golang.org/x/tools/gopls@v0.12.0

Support changes

As gopls matures, we're trying to simplify its configuration so that gopls Just Works in more scenarios, and so that we have fewer configuration combinations to test. This means that we will be gradually deprecating settings that affect the core behavior of gopls.

Removed experimental configuration options

As announced in the v0.10.0 release notes, this release removes support for the experimentalWorkspaceModule and experimentalWatchedFileDelay settings. The experimentalPackageCacheKey setting is also removed, as it is irrelevant in the new design.

The experimentalWorkspaceModule setting in particular may still be in use by some users. This setting has been superseded by built-in support for multi-module workspaces in the go command, via Go workspaces. To get the equivalent behavior in gopls@v0.12.0, please create a go.work file in your workspace using all desired modules. To use all modules in your workspace, run:

go work use -r .

Dropped support for Go 1.13-1.15, deprecated support for Go 1.16-1.17

As announced in the v0.10.0 release notes, this release drops support for Go 1.13-1.15, and in fact does not build with these Go versions.

Additionally, gopls@v0.12.x will be the final sequence of versions supporting Go 1.16-1.17, and therefore displays a deprecation notice when used with these Go versions.

Supported operating systems

Given that our users are almost entirely on Linux, Windows, or Darwin, we are discussing narrowing our support to focus on those operating systems, in golang/go#59981.

Performance improvements

The banner feature of this release is an internal redesign that significantly improves the way gopls scales in larger codebases. Performance, particularly memory usage, has long been a pain point for our users.

Reduced memory usage

Previous releases of gopls held typed syntax trees for all packages, in memory, all the time. With this release, these large data structures are ephemeral: as soon as they are constructed, an index of information derived from them is saved persistently to a file-based cache, and the data structures are recycled. The index for each package includes the locations of declaring and referring identifiers; the set of exported declarations and their types; the method sets of each interface; and any diagnostics and facts (see below) produced during analysis. The index holds all the information needed to serve global-scope LSP queries such as “references”, “implementations”, and so on.

Moving package information to a file-based cache greatly reduces the amount of RAM gopls uses, by almost an order of magnitude in larger projects. The table below shows the reductions in steady-state memory usage for three open-source Go repositories.

Project Packages In-use bytes v0.11.0 v0.12.0 Change
gopls 405 497MB 232MB -53%
kubernetes 3137 3090MB 832MB -73%
google-cloud-go + submods 7657 5039MB 863MB -83%

... (truncated)

Commits
  • 229f848 gopls/internal/lsp/source: enable new defers analyzer
  • 2dc7eba go/analysis: use parser.SkipObjectResolution
  • f91c023 go.mod: update golang.org/x dependencies
  • e0783a8 internal/gcimporter: remove bug report on objectpath failure
  • 75f6f9c gopls/internal/bug: add gopls/bug telemetry counter
  • 4b271f9 gopls: add gopls/client telemetry counters
  • d0b18e2 go/analysis/passes/copylock: fix infinite recursion
  • 5b4d426 gopls/internal/hooks: clean language version before passing to gofumpt
  • 2160c5f gopls/internal/lsp/analysis: fix stubmethods with variadic parameters
  • 3d20bbe internal/gcimporter: add a missing return if objectpath fails
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Aug 7, 2023
@dependabot
build(deps): Bump golang.org/x/tools from 0.11.1 to 0.12.0
b1783dc 
Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.11.1 to 0.12.0.
- [Release notes](https://github.com/golang/tools/releases)
- [Commits](golang/tools@v0.11.1...v0.12.0)

---
updated-dependencies:
- dependency-name: golang.org/x/tools
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/golang.org/x/tools-0.12.0 branch from c7db353 to b1783dc Compare August 11, 2023 22:27
@mharwani mharwani merged commit 09d6514 into main Aug 14, 2023
15 checks passed
@mharwani mharwani deleted the dependabot/go_modules/golang.org/x/tools-0.12.0 branch August 14, 2023 07:05
@github-actions github-actions bot mentioned this pull request Aug 14, 2023
Merged
KevinLiAWS pushed a commit that referenced this pull request Aug 16, 2023
@github-actions
chore(main): release 0.8.0 (#499)
ae6bb7d 
🤖 I have created a release *beep* *boop*
---


## [0.8.0](v0.7.0...v0.8.0)
(2023-08-16)


### Features

* adding config option for SOCI installation on VM
([#506](#506))
([a2e077b](a2e077b))


### Bug Fixes

* configure aws creds in sync submodules/deps action
([#518](#518))
([b67452e](b67452e))
* give pull request write permissions to sync job
([#520](#520))
([55b5235](55b5235))
* give token write perms to sync-submodules
([#519](#519))
([8b639ea](8b639ea))
* Mount /var/folders to finch vm
([#525](#525))
([c97d2e9](c97d2e9))
* option to use installed lima for SOCI e2e tests
([#533](#533))
([8b66659](8b66659))
* quote recursive calls to make
([#515](#515))
([d603096](d603096))
* Restart buildkit after containerd when provisioning
([#461](#461))
([fca1828](fca1828))


### Build System or External Dependencies

* **deps:** Bump github.com/docker/cli from 24.0.4+incompatible to
24.0.5+incompatible
([#495](#495))
([e9e8617](e9e8617))
* **deps:** Bump github.com/docker/docker from 24.0.4+incompatible to
24.0.5+incompatible
([#497](#497))
([6f1afbb](6f1afbb))
* **deps:** Bump github.com/lima-vm/lima from 0.16.0 to 0.17.2
([#531](#531))
([6e33d15](6e33d15))
* **deps:** Bump github.com/onsi/gomega from 1.27.8 to 1.27.10
([#496](#496))
([d08d102](d08d102))
* **deps:** Bump github.com/pkg/sftp from 1.13.5 to 1.13.6
([#530](#530))
([09b3846](09b3846))
* **deps:** Bump github.com/shirou/gopsutil/v3 from 3.23.6 to 3.23.7
([#513](#513))
([83bd718](83bd718))
* **deps:** Bump golang.org/x/tools from 0.11.0 to 0.11.1
([#509](#509))
([e826bcf](e826bcf))
* **deps:** Bump golang.org/x/tools from 0.11.1 to 0.12.0
([#523](#523))
([09d6514](09d6514))
* **deps:** Bump k8s.io/apimachinery from 0.27.3 to 0.27.4
([#487](#487))
([444bbc0](444bbc0))
* **deps:** Bump k8s.io/apimachinery from 0.27.4 to 0.28.0
([#535](#535))
([8df84cf](8df84cf))
* **deps:** Bump submodules and dependencies
([#521](#521))
([1b3ad94](1b3ad94))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mharwani mharwani mharwani approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mharwani