Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't test coverage of tests #59

Merged
merged 1 commit into from Jun 6, 2020
Merged

Don't test coverage of tests #59

merged 1 commit into from Jun 6, 2020

Conversation

kbrock
Copy link
Collaborator

@kbrock kbrock commented Jun 6, 2020

Kinda pointless to test the coverage of the tests

@kbrock kbrock added the cleanup label Jun 6, 2020
@kbrock kbrock requested a review from jrafanie June 6, 2020 00:00
@kbrock
Copy link
Collaborator Author

kbrock commented Jun 6, 2020 •
edited

@jrafanie second opinion - I'll merge if you're ok

OOPS. hoping you were ok ;)

@coveralls
Copy link

coveralls commented Jun 6, 2020 •
edited

Pull Request Test Coverage Report for Build 77

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.7%) to 96.664%
Totals Coverage Status
Change from base Build 76: -1.7%
Covered Lines: 1043
Relevant Lines: 1079
💛 - Coveralls

@kbrock
Copy link
Collaborator Author

kbrock commented Jun 6, 2020

For some reason the percentages in the coverage for the test file is very volatile.
Which is strange because it should just always be 100%...

I'm hoping that removing this will stabilize the coverage numbers

@kbrock kbrock merged commit 5b9c8e6 into ruport:master Jun 6, 2020
@kbrock kbrock deleted the test_coverage branch June 6, 2020 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrafanie jrafanie Awaiting requested review from jrafanie

Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kbrock @coveralls