Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write_XXXX function parameters #12

Closed
rkrupnek opened this issue Aug 15, 2016 · 2 comments
Closed

Write_XXXX function parameters #12

rkrupnek opened this issue Aug 15, 2016 · 2 comments

Comments

@rkrupnek
Copy link

The pycomm.ab_comm.clx.Driver has the default order of parameters (value & data type) switched for write_tag vs write_array. It seems like this would be easier to keep straight if they were the same. However, I may be all wet on this, and you might have a very good reason for doing it that way.

def write_tag(self, tag, value=None, typ=None):
...
vs
def write_array(self, tag, data_type, values, raw=False):
...

@ruscito
Copy link
Owner

ruscito commented Sep 10, 2016

That's a good catch. There is now good reason beside the method signature, and you are right it should be consistent across the other methods. However, if I change it now there will be a compatibility issue with who using the library now. That's not an easy call lets put it on StrawPoll and see the feedback

@ruscito ruscito closed this as completed Sep 10, 2016
@ruscito ruscito reopened this Sep 11, 2016
@ruscito
Copy link
Owner

ruscito commented Nov 12, 2016

Following the poll result I changed the order for the parameter

@ruscito ruscito closed this as completed Nov 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants