ETB overheats due to constant isTpsError true/false/true/false jitter…

…: this seems obvious enough to disable ETB at least on non running engine #4832 better default for 16 bit fields
rusefi · Nov 30, 2022 · 511a6be · 511a6be
1 parent a6a111c
commit 511a6be
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 4 deletions.
diff --git a/firmware/integration/rusefi_config.txt b/firmware/integration/rusefi_config.txt
@@ -1349,7 +1349,7 @@ custom stepper_num_micro_steps_e 1 bits, U08,	@OFFSET@,	[0:3], @@stepper_num_mic
 
     int8_t launchFuelAdderPercent
 	int8_t[1 iterate] sorryUnused
-	int16_t etbExpAverageLength
+	uint16_t etbExpAverageLength
 	float etbDutyThreshold
 
 	int16_t coastingFuelCutRpmHigh;This sets the RPM above which fuel cut is active.;"rpm", 1, 0, 0, 5000, 0

diff --git a/java_tools/ConfigDefinition.jar b/java_tools/ConfigDefinition.jar
diff --git a/java_tools/configuration_definition/src/main/java/com/rusefi/ConfigField.java b/java_tools/configuration_definition/src/main/java/com/rusefi/ConfigField.java
@@ -267,6 +267,9 @@ public String getName() {
         return name;
     }
 
+    /**
+     * @see com.rusefi.newparse.parsing.Type
+     */
     public String getType() {
         return type;
     }

diff --git a/java_tools/configuration_definition/src/main/java/com/rusefi/output/TsOutput.java b/java_tools/configuration_definition/src/main/java/com/rusefi/output/TsOutput.java
@@ -4,6 +4,7 @@
 import com.rusefi.ConfigField;
 import com.rusefi.ReaderState;
 import com.rusefi.TypesHelper;
+import com.rusefi.newparse.parsing.Type;
 
 import java.util.TreeSet;
 
@@ -156,8 +157,11 @@ public int writeOneField(FieldIterator it, String prefix, int tsPosition) {
     private String handleTsInfo(ConfigField configField, String tsInfo, int multiplierIndex) {
         if (tsInfo == null || tsInfo.trim().isEmpty()) {
             // default units and scale
-            if (isConstantsSection)
+            if (isConstantsSection) {
+                if (configField.getType().equalsIgnoreCase(Type.U16.cType) || configField.getType().equalsIgnoreCase(Type.S16.cType))
+                    return quote("") + ", 1, 0, 0, 32000, 0";
                 return quote("") + ", 1, 0, 0, 100, 0";
+            }
             return quote("") + ", 1, 0";
         }
         try {

diff --git a/java_tools/configuration_definition/src/test/java/com/rusefi/test/ConfigFieldParserTest.java b/java_tools/configuration_definition/src/test/java/com/rusefi/test/ConfigFieldParserTest.java
@@ -82,15 +82,15 @@ public void testCustomEnum() {
                 "custom ego_sensor_e 1 bits, S08, @OFFSET@, [0:1], @@ego_sensor_e_enum@@\n" +
                 "ego_sensor_e afr_type1;\n" +
                 "ego_sensor_e afr_type2;\n" +
-                "int8_t int\n" +
+                "int16_t int\n" +
                 "end_struct\n";
         ReaderState state = new ReaderState();
 
         TestTSProjectConsumer tsProjectConsumer = new TestTSProjectConsumer("", state);
         state.readBufferedReader(test, tsProjectConsumer);
         assertEquals("afr_type1 = bits, S08, 0, [0:1], \"BPSX\", \"Innovate\", \"14Point7\"\n" +
                 "afr_type2 = bits, S08, 1, [0:1], \"BPSX\", \"Innovate\", \"14Point7\"\n" +
-                "int = scalar, S08, 2, \"\", 1, 0, 0, 100, 0\n" +
+                "int = scalar, S16, 2, \"\", 1, 0, 0, 32000, 0\n" +
                 "; total TS size = 4\n", tsProjectConsumer.getContent());
     }