Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETB overheats due to constant isTpsError true/false/true/false jitter: this seems obvious enough to disable ETB at least on non running engine #4832

Closed
rusefillc opened this issue Nov 27, 2022 · 11 comments
Labels

Comments

@rusefillc
Copy link
Contributor

Proteus
default settings
VAG ETB
https://rusefi.com/online/view.php?log=1111

evil combination over-heats TLE9201 on Proteus while consuming around 5A

image

@rusefillc
Copy link
Contributor Author

@mck1117 @ElDominio we can definitely detect that condition of isTpsError jitter

Question: how do we handle it? Turn throttle off for 10 seconds? what if we are in the middle of a turn? take whatever TPS value and apply it for next 1 second? else?

@ElDominio
Copy link
Collaborator

I downloaded the log, I can see isTpsError is 1 for maybe 0.01 seconds at a time; is duty being set to 0 when this happens? On most ETB systems I have seen, errors are summed and when it goes over a certain amount of errors for a certain amount of time (or even, only if the error state is true for more than a second), THEN ETB is considered failed and ETB duty set to zero, probably for this reason

@mck1117
Copy link
Member

mck1117 commented Nov 27, 2022

what if we just change the defaults so they're invalid for all throttles? Correct me if I'm wrong, but the loop we get here is

  1. default throttle calibration is sometimes valid for this throttle
  2. ECU tries to control throttle
  3. driver chip overheats
  4. user is unable to autocalibrate because chip may be overtemp'd
  5. user stuck with bad defaults

@mck1117
Copy link
Member

mck1117 commented Nov 27, 2022

evil combination over-heats TLE9201 on Proteus while consuming around 5A

How did you power Proteus in this scenario?

@ElDominio
Copy link
Collaborator

But i can do calibration just fine? Or are you talking about PID calibration?

rusefillc pushed a commit that referenced this issue Nov 27, 2022
@rusefillc rusefillc changed the title ETB overheats due to constant isTpsError true/false/true/false jitter ETB overheats due to constant isTpsError true/false/true/false jitter: this seems obvious enough to disable ETB at least on non running engine Nov 30, 2022
rusefillc added a commit that referenced this issue Nov 30, 2022
…: this seems obvious enough to disable ETB at least on non running engine #4832
rusefillc added a commit that referenced this issue Nov 30, 2022
…: this seems obvious enough to disable ETB at least on non running engine #4832
@ElDominio
Copy link
Collaborator

Hello, this is to report that the problem was indeed PID settings, and i used vales that seem logical (P close to 1, i close to 10-15, D close to .1) and the TLS is cool to the touch. I suggest PID autocal uses old vales to start, so it is more of an aid than a "we can do this automatigically"

But in the end, the problem is no more. Thanks everyone

@mck1117
Copy link
Member

mck1117 commented Nov 30, 2022

can you create a log of good/bad PIDs?

@rusefillc
Copy link
Contributor Author

@ElDominio here we have "ETB overheats due to constant isTpsError true/false/true/false jitter: this seems obvious enough to disable ETB at least on non running engine" which is NOT something you have experienced

PID drama would be #4833

@ElDominio
Copy link
Collaborator

Very bad PID settings -> https://rusefi.com/online/view.php?log=1103 ; https://rusefi.com/online/view.php?msq=1312

Working PID (driver is only warm to the touch) -> https://rusefi.com/online/view.php?msq=1321

rusefillc added a commit that referenced this issue Nov 30, 2022
…: this seems obvious enough to disable ETB at least on non running engine #4832

better default for 16 bit fields
@rusefillc
Copy link
Contributor Author

rusefillc added a commit that referenced this issue Dec 1, 2022
…: this seems obvious enough to disable ETB at least on non running engine #4832
rusefillc added a commit that referenced this issue Dec 1, 2022
…: this seems obvious enough to disable ETB at least on non running engine #4832
@nmschulte
Copy link
Contributor

nmschulte commented Jan 2, 2023

FWIW, while I was testing Toyota ETCS-i / partial redundant TPS (#4898/#4896), I ran into a situation where the ETB was trying to command a TPS value that it could not achieve, and caused huge current draw. I don't recall the exact situation, but it had to do with a certain tpsSecondaryMaximum (partial redundancy cut-over) causing a stepwise discrepancy when switching to partial redundancy, preventing the TPS from ever reading the commanded value. If I re-create it I'll share more detail, but wanted to capture it here for now. Thinking now, I don't think the TPS was erroring in my case, however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants