https://github.com/rusefi/hellen-112-17/issues/25

only:hellen-112-17
rusefi · Oct 15, 2023 · d44ae74 · d44ae74
1 parent 7c12648
commit d44ae74
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/firmware/config/boards/hellen/hellen-112-17/board.mk b/firmware/config/boards/hellen/hellen-112-17/board.mk
@@ -17,5 +17,6 @@ DDEFS += -DFIRMWARE_ID=\"hellen-112-17\" $(VAR_DEF_ENGINE_TYPE)
 
 DDEFS += -DSHORT_BOARD_NAME=hellen-112-17
 DDEFS += -DHW_HELLEN_K=TRUE
+DDEFS += -DHELLEN_BOARD_ID_DEBUG
 
 include $(BOARDS_DIR)/hellen/hellen-common100.mk
diff --git a/firmware/config/boards/hellen/hellen_common.cpp b/firmware/config/boards/hellen/hellen_common.cpp
@@ -67,7 +67,7 @@ void configureHellenCanTerminator() {
 }
 
 // this should be called before setHellenXXXLedPins()
-void detectHellenMcuType() {
+static void detectHellenMcuType() {
 	// we test the red LED1 pin because the red LED used has the smallest voltage drop,
 	// and thus can be detected more accurately
 	static const brain_pin_e led1Pins[2] = {
@@ -101,11 +101,10 @@ void detectHellenMcuType() {
 	efiPrintf("Hellen board pin states = %d %d", padState[0], padState[1]);
 	if (padState[0] && !padState[1]) {
 		efiPrintf("* Hellen 176-pin mcu detected!");
-	}
-	else if (!padState[0] && padState[1]) {
+	} else if (!padState[0] && padState[1]) {
 		efiPrintf("* Hellen 144-pin mcu detected!");
 	} else {
-		efiPrintf("* Cannot detect Hellen mcu module!");
+		efiPrintf("* Cannot figure if legacy 144 or 176 Hellen mcu module!");
 	}
 }