-
-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring, technical debt: export more of trigger attributes into triggers.txt file #2077
Comments
that's another reason to flip trigger workflow instead of C generating triggers.txt we shall have triggers.yaml generating C and java and .ini |
@chuckwagoncomputing how can I trick you into this issue? |
Which .ini? |
So the trigger info should be taken out of those files, and the yaml should be passed to ConfigDefinition. |
Also most of https://github.com/rusefi/rusefi/tree/master/firmware/controllers/trigger/decoders should be replaced by something generated by new java code based on triggers.yaml |
by the way firing order tool is somewhat similar just much simpler |
Depends on #2607 |
…riggers.txt file #2077 only extracting methods without any changes to the logic
…riggers.txt file #2077 some pretty dead code and moving methods
…riggers.txt file #2077 moving methods
Wow a minor sad discovery #4032 |
What is the current state of this? |
a lot of progress was done! at least nice names are still in java and should be moved into firmware as EFI_UNIT_TEST field? Actually human-readable name could be the last thing to move out of java
|
At the moment most of trigger parameters are defined in C code and exported into triggers.txt for TriggerImage java code to render, but some stuff is hard coded in java
all data about trigger should be defined in one place and at the moment that one place is C trigger definition structure
We should remove all hard-coded stuff from java and hard-code anything missing in C
The text was updated successfully, but these errors were encountered: