-
-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generate java enum from C enum? generate both C and java from yaml? #2102
Comments
we already read C .h see gen_enum_to_string.sh so some building pieces are already there |
|
Just to be clear, we decided that we want to generate the Java enum from the C enum, and not have a .yaml. Is that correct? |
yes, not yaml as source but C |
but that leaves question of how to define human-readable TS literals |
What about writing C from the info from rusefi_config.txt? |
We are already writing rusefi_generated.h. Does that not contain all the information that C needs, just not in an enum? |
text has horrible by index management, it's a nightmare to support @mck1117 @andreika-git ideas? |
Where are the TS engine types currently? I see the trigger type names in rusefi_config.txt, but not engine type names. |
engine types not in TS, I was talking generally output pins would be a case of scary enum drama for TS >> C mapping |
So you are interested in reading more things from C and removing them from rusefi_config.txt, and want to follow the same pattern? |
there is clearly a problem with manual sync of entities but also no great solution at the moment I am not happy with yaml as source of truth here, my preference is C as source of enums but literals are needed, maybe extend java enum reader to parse VAL/name=Value/=3, |
…2102 refactoring: code duplication
…2102 refactoring: code duplication
Done! |
at the moment in order to sync C and java enums we have the
in .txt while both C and java is generated
it would be more efficient to generate some java based on C .h header without .txt involvment
The text was updated successfully, but these errors were encountered: