Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger setup in TS is highly confusing: hide operation mode from users? #4031

Closed
rusefillc opened this issue Apr 2, 2022 · 4 comments
Closed
Labels

Comments

@rusefillc
Copy link
Contributor

We already only use "operation mode" for skipped wheel triggers

Question: do we even need it for skipped wheel triggers? shall we just declare that all skipped wheel triggers are always crank-based?

@rusefillc
Copy link
Contributor Author

@ElDominio
Copy link
Collaborator

No, I do a lot of Toyota skipped tooth on cam by grinding a tooth off the 24 tooth trtigger, it's usually the best choice even thought it has a +1.

Also, the Aprilia 500cc engine is 48-2 on cam from the factory.

@rusefillc
Copy link
Contributor Author

What users see now is called
engineConfiguration->ambiguousOperationMode

which is passed into initializeTriggerWaveform method - note how limited usages are already

@ElDominio
Copy link
Collaborator

Operation mode means where the trigger is located? Can't they have an option like say,

Primary trigger location: Crank/Cam

Secondary is always cam so that's that, but the primary trigger location should be selctable

rusefillc added a commit that referenced this issue Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants