Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VVT target to allow negative values #4424

Closed
ElDominio opened this issue Aug 9, 2022 · 12 comments · Fixed by #4464
Closed

VVT target to allow negative values #4424

ElDominio opened this issue Aug 9, 2022 · 12 comments · Fixed by #4464
Assignees

Comments

@ElDominio
Copy link
Collaborator

ElDominio commented Aug 9, 2022

4B11 VVT issues: positive duty makes Exhaust VVT go negative

As title says, that happens, but VVT angle cannot be negative. Need to target negative angle since this is expected operation

@rusefillc
Copy link
Contributor

duty? angle? I am very confused

tune URL is best

@ElDominio
Copy link
Collaborator Author

https://rusefi.com/online/index.php?vehicleName=Lancer+NotEvo+fifrst&user_id=675&sorts[uploadedMsq]=-1&sorts[uploadedLog]=-1

Increasing exhaust VVT duty makes the VVT angle go into negative numbers (when idling at 0 degrees)

@rusefillc
Copy link
Contributor

@ElDominio what is "actual behaviour" and what is "expected behaviour"

I am starting to wonder if that's about VVT target table not allowing negative values

Are you asking for VVT target to start accepting negative values?

image

@ElDominio
Copy link
Collaborator Author

Correct, that would be best

@rusefillc rusefillc changed the title 4B11 VVT issues: positive duty makes Exhaust VVT go negative VVT target to allow negative values Aug 9, 2022
@rusefillc
Copy link
Contributor

just a reminer that you would need to lower PID min value to include your negative range

@mck1117
Copy link
Member

mck1117 commented Aug 9, 2022

there's a other step, the control is reversed for his exhaust cam

@mck1117 mck1117 reopened this Aug 9, 2022
@mck1117 mck1117 assigned mck1117 and unassigned ElDominio Aug 9, 2022
@rusefillc
Copy link
Contributor

For reversed control do we simply use negative P?

@mck1117
Copy link
Member

mck1117 commented Aug 9, 2022

For reversed control do we simply use negative P?

It's much more user friendly to not do that.

@mck1117
Copy link
Member

mck1117 commented Aug 9, 2022

just a reminer that you would need to lower PID min value to include your negative range

PID min is the min output - not the min target

@rusefillc
Copy link
Contributor

rusefillc pushed a commit that referenced this issue Aug 9, 2022
@ElDominio
Copy link
Collaborator Author

https://rusefi.com/online/view.php?log=967

VVT exhaust angle target is negative, PID max and min are 90 and -90 respectively. No change in VVT angle, VVT direction for exhaust is set to "retard"

https://rusefi.com/online/view.php?log=968

This log has VVT direction set to "advance", and once the target is changed to a positive value(at about 30s), actual VVT goes rapidly towards -40 (max VVT angle on exhaust), I assume because the PID is seeing it get farther and farther away from +10 (the target) .

rusefillc pushed a commit that referenced this issue Aug 14, 2022
baby step towards VVT pid logging
rusefillc pushed a commit that referenced this issue Aug 14, 2022
baby step towards VVT pid logging
rusefillc pushed a commit that referenced this issue Aug 14, 2022
rusefillc added a commit that referenced this issue Aug 15, 2022
* We have to move either forward or backwards with newparse #4441

only spot where newparse was used for real?

* We have to move either forward or backwards with newparse #4441

.jar

* Struct array for outputs #4442

* Struct array for outputs #4442

* Struct array for outputs #4442

making kinetis happy :(

* VVT target to allow negative values #4424

Co-authored-by: rusefillc <sdfsdfqsf2334234234>
@ElDominio
Copy link
Collaborator Author

👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants