New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We have to move either forward or backwards with newparse #4441

Closed

rusefillc opened this issue Aug 14, 2022 · 2 comments

Assignees

Contributor

rusefillc commented Aug 14, 2022

I am unhappy with what seems like abandoned newparse approach. @mck1117 please either clearly commit to finish this refactoring or undo it into a consistent legacy approach

Specifically I do not like TsWriter#writeTunerstudio dead method
Specifically I do not like OutputsSectionConsumer being used only by one or two tests
etc etc etc

In the current state in my opinion the unfinished effort does more bad than good.

rusefillc assigned mck1117

Contributor Author

rusefillc commented Aug 14, 2022

required for #4442

rusefillc pushed a commit that referenced this issue


          TODO: We have to move either forward or backwards with newparse #4441

4c93418

Contributor Author

rusefillc commented Aug 14, 2022

related to #4219

rusefillc pushed a commit that referenced this issue


          We have to move either forward or backwards with newparse #4441

abf648e

only spot where newparse was used for real?

rusefillc pushed a commit that referenced this issue


          We have to move either forward or backwards with newparse #4441

484a9f1

.jar

rusefillc pushed a commit that referenced this issue


          We have to move either forward or backwards with newparse #4441

784d9b5

only spot where newparse was used for real?

rusefillc pushed a commit that referenced this issue


          We have to move either forward or backwards with newparse #4441

bc51813

.jar

rusefillc pushed a commit that referenced this issue


          We have to move either forward or backwards with newparse #4441

278c05a

only spot where newparse was used for real?

rusefillc pushed a commit that referenced this issue


          We have to move either forward or backwards with newparse #4441

1d24b00

.jar

rusefillc pushed a commit that referenced this issue


          We have to move either forward or backwards with newparse #4441

d9faffa

only spot where newparse was used for real?

rusefillc pushed a commit that referenced this issue


          We have to move either forward or backwards with newparse #4441

.jar

rusefillc pushed a commit that referenced this issue


          We have to move either forward or backwards with newparse #4441

only spot where newparse was used for real?

rusefillc pushed a commit that referenced this issue


          We have to move either forward or backwards with newparse #4441

50cb83e

.jar

rusefillc added a commit that referenced this issue


          A safe place where stuff is consistent (#4444)

15d42bd

* We have to move either forward or backwards with newparse #4441

only spot where newparse was used for real?

* We have to move either forward or backwards with newparse #4441

.jar

* Struct array for outputs #4442

* Struct array for outputs #4442

* Struct array for outputs #4442

making kinetis happy :(

* VVT target to allow negative values #4424

Co-authored-by: rusefillc <sdfsdfqsf2334234234>

rusefillc pushed a commit that referenced this issue


          We have to move either forward or backwards with newparse #4441

afc376b

a step back anticipating changes

mck1117 added a commit to mck1117/rusefi that referenced this issue


          Revert "We have to move either forward or backwards with newparse rus…

be4f95a

…efi#4441"

This reverts commit afc376b.

mck1117 mentioned this issue

new parser writes datalogs #4287

Closed

rusefillc pushed a commit that referenced this issue


          We have to move either forward or backwards with newparse #4441

752a10e

rusefillc pushed a commit that referenced this issue


          We have to move either forward or backwards with newparse #4441

438155d

rusefillc pushed a commit that referenced this issue


          We have to move either forward or backwards with newparse #4441

18a92a9

rusefillc pushed a commit that referenced this issue


          We have to move either forward or backwards with newparse #4441

72292e5

rusefillc closed this as completed in

9cae8ec

rusefillc added a commit that referenced this issue


          only:We have to move either forward or backwards with newparse #4441

eb651dc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment