Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch RPM + Launch Control window is not correct #6533

Closed
ElDominio opened this issue May 21, 2024 · 1 comment
Closed

Launch RPM + Launch Control window is not correct #6533

ElDominio opened this issue May 21, 2024 · 1 comment
Assignees

Comments

@ElDominio
Copy link
Collaborator

Describe the bug
Launch RPM does not cut the selected method at the Launch RPM, but at Launch + Window

Hardware

  • Board: 4chan revB
  • Engine info 3A92

To Reproduce
Advanced -> Launch Control
use settings in screenshot

Screenshots
image_2024-05-21_15-35-02

Expected behavior
I expect that at "Launch RPM", the configured "Hard Mode" in the screenshot is implemented. If I choose "ignition cut" under Hard Mode, then ignition is completley disabled at values greater than Launch RPM.

The "Launch Control Window" setting should start implementing launch control procedures BEFORE the Launch RPM, meaning, if I have my settings in the screenshot (Ignition Retard Enable = true, 10 degrees of timing, 0% fuel added, smooth retard mode) as such, they should start affecting the car BEFORE Launch RPM which is 2500.

This means that at 2000RPM (2500-500), I want to remove 10 degrees of timing, add 0% of fuel, and not use smooth retard mode. If I ever get to 2501RPM, I want to cut Ignition completely until i get to 2499RPM.

Additional context
tune and log:
https://rusefi.com/online/view.php?log=1400

kifir23917 added a commit to kifir23917/rusefi that referenced this issue May 21, 2024
@ElDominio
Copy link
Collaborator Author

With the update, it now cuts at the Launch RPM, and stays off until it reaches Launch RPM - Launch Control Window.

It is much better, but I think that the Hard Cut method should only be used when OVER the Launch RPM, not regarding the Window. The Window only dictates when the prelaunch parameters start taking place.

Log:
https://rusefi.com/online/view.php?log=1401
in this log i changed Window from 200 to 500 mid test.

https://rusefi.com/online/view.php?log=1402
this log is set at 500 launch window

kifir23917 added a commit to kifir23917/rusefi that referenced this issue May 22, 2024
kifir23917 added a commit to kifir23917/rusefi that referenced this issue May 22, 2024
kifir23917 added a commit to kifir23917/rusefi that referenced this issue May 22, 2024
kifir23917 added a commit to kifir23917/rusefi that referenced this issue May 22, 2024
kifir23917 added a commit to kifir23917/rusefi that referenced this issue May 23, 2024
kifir23917 added a commit to kifir23917/rusefi that referenced this issue May 23, 2024
kifir23917 added a commit to kifir23917/rusefi that referenced this issue May 23, 2024
kifir23917 added a commit to kifir23917/rusefi that referenced this issue May 24, 2024
kifir23917 added a commit to kifir23917/rusefi that referenced this issue May 24, 2024
kifir23917 added a commit to kifir23917/rusefi that referenced this issue May 24, 2024
kifir23917 added a commit to kifir23917/rusefi that referenced this issue May 27, 2024
kifir23917 added a commit to kifir23917/rusefi that referenced this issue May 27, 2024
rusefillc pushed a commit that referenced this issue May 27, 2024
@rusefillc rusefillc added the bug label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants