-
-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new parser writes datalogs #4287
Conversation
…o write-datalog
My focus right now is on ae8eb30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please extract output_channels.txt change into separate PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that this PR should be removing TsOutput
Yes, that should be pretty easy shortly. |
that's still in use by the normal config generation, but not by live data |
I am failing to see the value of this change without TsOutput removal - as it it's introducing descepancy between two extremely similar tasks. I believe that TsOutput removal is the bare minimal of newparse if you choose to go with live data as first newparse usage. |
I don't understand your question. The live data tool as modified in this PR makes no call to TsOutput, but
|
my understaidnig of TsOutput constructor usages in master is "OutputsSectionConsumer and TSProjectConsumer are extremely similar" my common sense is "if we replace OutputsSectionConsumer same PR should also be replacing TSProjectConsumer " my common sense is "if we remove OutputsSectionConsumer same PR should also be removeing TSProjectConsumer " Q: does this PR treat OutputsSectionConsumer and TSProjectConsumer the same way by migrating those together? |
do we want to change random things, or seek some stability in the world? |
@mi-hol here we have a great idea which is I. The works for a couple of years and in my opinion the transition period of extra effort to maintain old and new is not justified @mck1117 I still believe that we should either completely migrate to newparse or officially give up. What do you think @mck1117? |
@rusefillc apologize but I fail to understand what you try to tell me. What I see is a harsh comment discouraging further progress on this matter. It's your choice how this will end up. From my view a balance between requirements of developer and owner are required to progress as a team. |
Abandoned |
#4441 let's move forward
fixes #4451