Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log to show a list of all relevant tunes #73

Closed
rusefi opened this issue Jul 13, 2020 · 10 comments
Closed

Log to show a list of all relevant tunes #73

rusefi opened this issue Jul 13, 2020 · 10 comments
Assignees

Comments

@rusefi
Copy link
Collaborator

rusefi commented Jul 13, 2020

On https://rusefi.com/online/view.php?log=15 we should have a table listing all timeframes which match any tunes on REO

ideally the toolset should be smart to add more links if additional tunes are loaded after log is loaded

in case of no tune matching for specific time ranges "Unknown tune" should be presented

@andreika-git
Copy link
Collaborator

Please specify the exact place for the table.
Please specify the format of the table (title, column names).
Please specify how the additional tunes differ from the directly related ones.

@rusefi
Copy link
Collaborator Author

rusefi commented Jul 14, 2020

@andreika-git exactly above the footer, between all current content and footer

Timeframe Tune Diff with prev Note
0:00 - 2:04 22:23 tune URL URL to diff to previous tune note from 22:23 tune
2:04 - 5:00 Unknown tune

"diff URL" is a dream related to diff feature covered by a separate ticket

@rusefillc
Copy link
Contributor

https://rusefi.com/online/view.php?msq=191

BinaryProtocol - From rusEFI tune CRC16 0x161 353

crc16=353 matches new "crc16" gauge

image

@rusefillc
Copy link
Contributor

https://rusefi.com/online/view.php?msq=192

4621 is proper new CRC16
image

https://rusefi.com/online/view.php?log=24 seem to have both valid crc16

rusefillc added a commit to rusefi/rusefi that referenced this issue Aug 14, 2020
rusefillc added a commit to rusefi/rusefi that referenced this issue Aug 14, 2020
@rusefillc
Copy link
Contributor

crc16 was wrong because of wrong engine_type definition in TS project. This is now fixed and engine type in TS project uses new feature of code generator

rusefi/rusefi#1693 created to address similar issue on a larger scale

@rusefillc
Copy link
Contributor

@andreika-git
Copy link
Collaborator

URL to diff to previous tune
What's the text of the url? And if there's only 1 record (no previous one), what text should it be?

@rusefillc
Copy link
Contributor

for now let's use "XXX" text just to have a prototype

@andreika-git
Copy link
Collaborator

rusefi/msqur@b571796

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants