Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Connection path field #1248

Merged
merged 2 commits into from
Dec 11, 2022
Merged

Remove Connection path field #1248

merged 2 commits into from
Dec 11, 2022

Conversation

gwenn
Copy link
Collaborator

@gwenn gwenn commented Nov 8, 2022

Use sqlite3_db_filename instead.
Pros: memory footprint, absolute path
Cons: one cannot make the disctinction between multiple memory databases anymore (like file:one.db?mode=memory and file:another.db?mode=memory).

Use sqlite3_db_filename instead.
Pros: memory footprint, absolute path
Cons: one cannot make the disctinction between multiple memory
databases anymore (like file:one.db?mode=memory and
file:another.db?mode=memory).
@gwenn gwenn requested a review from thomcc November 8, 2022 19:52
@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Base: 66.00% // Head: 66.04% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (8a28167) compared to base (cc2c290).
Patch coverage: 87.50% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1248      +/-   ##
==========================================
+ Coverage   66.00%   66.04%   +0.04%     
==========================================
  Files          45       45              
  Lines        3759     3752       -7     
==========================================
- Hits         2481     2478       -3     
+ Misses       1278     1274       -4     
Impacted Files Coverage Δ
src/lib.rs 65.23% <87.50%> (+0.65%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gwenn gwenn merged commit 9e76bf4 into rusqlite:master Dec 11, 2022
@gwenn gwenn deleted the db_path branch December 11, 2022 08:41
gwenn added a commit to gwenn/rusqlite that referenced this pull request Dec 13, 2022
@gwenn gwenn mentioned this pull request Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant